Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document tuple support in Active Record where clauses #49116

Merged
merged 1 commit into from Sep 5, 2023
Merged

Document tuple support in Active Record where clauses #49116

merged 1 commit into from Sep 5, 2023

Conversation

gmcgibbon
Copy link
Member

Motivation / Background

This Pull Request has been created because docs for tuple syntax in Active Record where clauses needs to be documented.

Detail

This Pull Request changes Active Record to add the appropriate docs.

Additional information

Adds documentation to ActiveRecord::QueryMethods#where mentioning tuple syntax support added in #47729.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@gmcgibbon gmcgibbon changed the title [skip ci] Document tuple support in Active Record where clauses Document tuple support in Active Record where clauses Sep 1, 2023
akhilgkrishnan
akhilgkrishnan reviewed Sep 2, 2023
View reviewed changes
Copy link
Member

@akhilgkrishnan akhilgkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think comma is needed here.

activerecord/lib/active_record/relation/query_methods.rb Outdated Show resolved Hide resolved
@gmcgibbon
[skip ci] Document tuple support in Active Record where clauses
6d16512 
Adds documentation to ActiveRecord::QueryMethods#where mentioning tuple
syntax support added in rails#47729.
@eileencodes eileencodes merged commit ad83a66 into rails:main Sep 5, 2023
1 check failed
@gmcgibbon gmcgibbon deleted the where_tuple_docs branch September 5, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p8 p8 p8 left review comments

@akhilgkrishnan akhilgkrishnan akhilgkrishnan left review comments

@rafaelfranca rafaelfranca rafaelfranca approved these changes

@nvasilevski nvasilevski nvasilevski approved these changes

Assignees
No one assigned
Labels
activerecord
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gmcgibbon @p8 @rafaelfranca @nvasilevski @akhilgkrishnan @eileencodes