Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[skip ci] Description added for ActiveRecord::Base.generates_token_for method in 7.1 release note #49118

Merged
merged 1 commit into from Sep 5, 2023
Merged

[skip ci] Description added for ActiveRecord::Base.generates_token_for method in 7.1 release note #49118

merged 1 commit into from Sep 5, 2023

Conversation

akhilgkrishnan
Copy link
Member

@akhilgkrishnan akhilgkrishnan commented Sep 2, 2023 •
edited

Detail

This Pull Request adds the description for ActiveRecord::Base.generates_token_for method in the rails 7.1 release note.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@rails-bot rails-bot bot added the docs label Sep 2, 2023
@akhilgkrishnan
[skip ci] Description added for ActiveRecord::Base.generates_token_fo…
7d80ccb 
…r method in 7.1 release note

[skip ci] Added PR reference

[skip ci] review changes updated

[skip ci] review changes updated
@rafaelfranca rafaelfranca merged commit 5bd10ff into rails:main Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulreece paulreece paulreece left review comments

@vipulnsward vipulnsward Awaiting requested review from vipulnsward

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@akhilgkrishnan @vipulnsward @paulreece @rafaelfranca