Rails Guides: describe composite primary keys (CPK) for migrations and querying #49150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianna-chang-shopify
deleted the
rails_guides_updates_for_composite_primary_keys
branch
eileencodes
reviewed
Sep 5, 2023
| @@ -199,6 +199,8 @@ SELECT * FROM customers WHERE (customers.id IN (1,10)) | |||
|
|
|||
| WARNING: The `find` method will raise an `ActiveRecord::RecordNotFound` exception unless a matching record is found for **all** of the supplied primary keys. | |||
|
|
|||
| If your table uses a composite primary key, you'll need to pass an array to find a single item. You can also pass an array of arrays to find multiple records. | |||
There was a problem hiding this comment.
I think this should include an example. Can you open a new PR that shows the find and sql generated like the above examples?
There was a problem hiding this comment.
That's a great idea. Will do.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the active_record_migrations guide, mention that a composite primary key can be specified using an array.
In the active_record_querying guide, mention that
findtakes an array or array of arrays for composite primary keys.Both of these are recent API changes, not yet mentioned in the Rails guides.