Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dedicate guide for composite primary keys [ci skip] #49205

Merged

Conversation

adrianna-chang-shopify
Copy link
Contributor

Motivation / Background

Adds a dedicated guide for composite primary key usage. Most of this content was compiled from other guides / documentation for composite primary keys, including:

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]

@rails-bot rails-bot bot added the docs label Sep 8, 2023
@adrianna-chang-shopify adrianna-chang-shopify changed the title Add dedicate guide for composite primary keys Add dedicate guide for composite primary keys [ci skip] Sep 8, 2023
Copy link
Contributor

@nvasilevski nvasilevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -0,0 +1,303 @@
**DO NOT READ THIS FILE ON GITHUB, GUIDES ARE PUBLISHED ON https://guides.rubyonrails.org.**
Copy link
Contributor

@nvasilevski nvasilevski Sep 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We seem to be following an existing pattern here but I wonder if Rails should reconsider having such strong message. It's good to encourage reading guides where we think the guides are best presented but also I see no reason to strongly discourage reading them on github if someone finds github more accessible for whatever reason.

Sorry for an off-topic!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's because otherwise we get PRs to "fix" the guides on github when they are already correct/fine on the guides website.

Co-authored-by: Noah Gibbs <noah.gibbs@shopify.com>
@adrianna-chang-shopify adrianna-chang-shopify merged commit 0debdcf into rails:main Sep 8, 2023
3 checks passed
@adrianna-chang-shopify adrianna-chang-shopify deleted the ac-cpk-guide branch September 8, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants