Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional docs to Query Interface guide about composite primary key models [ci skip] #49188

Conversation

adrianna-chang-shopify
Copy link
Contributor

@adrianna-chang-shopify adrianna-chang-shopify commented Sep 7, 2023

Added additional docs about ordering on the #first and #last methods for CPK models, as well as docs on the tuple-like syntax for hash conditions on the #where method.

I also mentioned the id_value method in the context of finder methods such as find_by and where, where usage with CPK models can be ambiguous. Open to feedback if there would be a better place to put this information. Does the example make sense? Is there value in highlighting that scenario?

@rails-bot rails-bot bot added the docs label Sep 7, 2023
@adrianna-chang-shopify adrianna-chang-shopify merged commit 006b917 into rails:main Sep 7, 2023
3 checks passed
@adrianna-chang-shopify adrianna-chang-shopify deleted the ac-document-more-finder-methods-cpk branch September 7, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants