-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve strict_loading
documentation [ci skip]
#49850
Improve strict_loading
documentation [ci skip]
#49850
Conversation
The API Documentation Guidelines' Links section doesn't cover when or how we should link to the guides from API docs. I think it would help me if I got this error, but I couldn't find any existing links from API docs to Guides, so let me know if I did a bad thing 😬 |
Thanks, can you squash your commits into one commit? |
* Update ActiveRecord::StrictLoadingViolationError API docs to reference the guide to help beginners learn how to resolve the error. * Update Active Record Query Interface guide to cover configuration and the association option. Apply suggestions from code review Co-authored-by: Eileen M. Uchitelle <eileencodes@users.noreply.github.com>
909dd7a
to
5101170
Compare
@eileencodes Done! Thanks for bearing with my P.S. I enjoyed your talk The Magic of Rails. It piqued my curiosity to explore Active Storage code as I write a small API client. |
Thanks for working on this! Good additions. 👏
There is a tiny blurb about it here, if you mean what I think you mean: In short, |
reference the guide to help beginners learn how to resolve the error.
the association option.
Motivation / Background
This Pull Request has been created to improve the docs and guides.
Detail
This Pull Request changes:
strict_loading
.Additional information
Explains the association option, highlighted in Chris Oliver's excellent Rails World talk Powerful Rails Features You Might Not Know.
Continues the nice additions in #49329
I was inspired by @zzak's comment on #49741
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]