Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve strict_loading documentation [ci-skip] #49329

Merged
merged 1 commit into from Sep 20, 2023
Merged

Improve strict_loading documentation [ci-skip] #49329

merged 1 commit into from Sep 20, 2023

Conversation

p8
Copy link
Member

@p8 p8 commented Sep 20, 2023 •
edited

Expand examples by adding singular associations.
Fix the :n_plus_one_only mode example, which doesn't raise an error for loading comments.
Expand the guides with strict_loading!.
Also add to_a to code examples as loading the associations is required to raise the errors.

image

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@p8 p8 force-pushed the guides/strict-loading-with-mode branch 2 times, most recently from 39149a1 to 8894b06 Compare September 20, 2023 11:54
@p8
Improve strict_loading documentation [ci-skip]
677fa58 
Expand examples by adding singular associations.
Expand the guides with `strict_loading!`.
Also add `to_a` to code examples as loading the associations is required
to raise the errors.
@p8 p8 force-pushed the guides/strict-loading-with-mode branch from 8894b06 to 677fa58 Compare September 20, 2023 11:54
@p8
Copy link
Member Author

p8 commented Sep 20, 2023

Thanks @adrianna-chang-shopify !

@p8 p8 merged commit 6f27e92 into rails:main Sep 20, 2023
3 checks passed
@p8 p8 deleted the guides/strict-loading-with-mode branch September 20, 2023 15:54
@ansonhoyt ansonhoyt mentioned this pull request Oct 30, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianna-chang-shopify adrianna-chang-shopify adrianna-chang-shopify approved these changes

Assignees
No one assigned
Labels
activerecord docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@p8 @adrianna-chang-shopify