Fix failing test due to the relative path output of minitest at v5.21.0 #50724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeroastro
changed the title
aeroastro
force-pushed
the
feature/fix-minitest-dependency
branch
from
c1d59a1
to
e5c2adc
Compare
|
It seems like one of the test containers are running for too long period due to issues on CI system side. It is very helpful if one of the members could rerun the test and merge this PR 🐱 |
aeroastro
force-pushed
the
feature/fix-minitest-dependency
branch
3 times, most recently
from
440adec
to
137951e
Compare
minitest has been updated to output relative paths for failures at v5.21.0 minitest/minitest@e410bad This patch fixes test to pass regardless of minitest versions.
aeroastro
force-pushed
the
feature/fix-minitest-dependency
branch
from
137951e
to
5853ff1
Compare
eileencodes
added a commit
that referenced
this pull request
Jan 12, 2024
Fix failing test due to the relative path output of minitest at v5.21.0
|
Thanks! Backported to 7-1-stable in 404e1fc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes failing test to pass regardless of minitest versions.
Motivation / Background
minitest has been updated to output relative paths for failures at v5.21.0
minitest/minitest@e410bad
This causes test failures of
test/generators/plugin_test_runner_test.rb:72Detail
This patch fixes the regular expression to run regardless of minitest versions.
Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]