Fix ActiveSupport::Notifications.publish_event to preserve units
#50779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: rails#43502 Fix: rails#50767 Fix: rails#50493 When republishing a an event into a `start, finish` tuple, we need to convert the timestamps back into seconds.
byroot
added a commit
that referenced
this pull request
Jan 17, 2024
Fix `ActiveSupport::Notifications.publish_event` to preserve units
byroot
added a commit
that referenced
this pull request
Jan 17, 2024
Fix `ActiveSupport::Notifications.publish_event` to preserve units
|
Backported to 7.1 and 7.0. |
rosa
added a commit
to rosa/yabeda-activejob
that referenced
this pull request
Mar 12, 2024
In Rails 7 this is seconds as per rails/rails#50779, that changes all times to be in seconds (done for Rails 7.2, and backported to Rails 7.1 and 7.0). This means that calling `Time.parse(time.to_s).utc` on a seconds value results in an ``` ArgumentError: argument out of range ```
rosa
added a commit
to rosa/yabeda-activejob
that referenced
this pull request
Mar 12, 2024
In Rails 7 this is seconds as per rails/rails#50779, that changes all times to be in seconds (done for Rails 7.2, and backported to Rails 7.1 and 7.0). This means that calling `Time.parse(time.to_s).utc` on a seconds value results in an ``` ArgumentError: argument out of range ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #43502
Fix: #50767
Fix: #50493
When republishing a an event into a
start, finishtuple, we need to convert the timestamps back into seconds.cc @fatkodima @rporrasluc
To be backported in 7.1 and 7.0