Fix calculation of Active Record :db_runtime metric #50493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byroot
added a commit
that referenced
this pull request
Dec 31, 2023
Fix calculation of Active Record :db_runtime metric
|
Thank you! Backported to 7-1-stable. |
4 tasks
casperisfine
pushed a commit
to Shopify/rails
that referenced
this pull request
Jan 17, 2024
Ref: rails#43502 Fix: rails#50767 Fix: rails#50493 When republishing a an event into a `start, finish` tuple, we need to convert the timestamps back into seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using async queries inside controllers, I noticed too large db runtime values and negative view runtime values in the logs, something like:
Turned out, that the problem is in a recent change from f56b418#diff-fc921d14f4dc8556c4b8cd785f350ec728fe07c8b884fbc3a0b4cbc9ec5eafffR28
There is no need to multiply by
1000, because the values are already in milliseconds.cc @byroot