Missed commits from 3-2-stable #5359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@avakhov hey.. my commit about missing About the others, I really don't know, but seems that there is no harm on merging them. Thanks! |
|
@carlosantoniodasilva sure, I see it. Remove this commit and rebase. |
|
@avakhov @josevalim thanks chaps! |
|
Any news on this one? |
… servers, Apache/Nginx are the web servers along with thin a la Heroku etc.
|
@spastorino I don't now. I rebased to keep them in fit. |
spastorino
added a commit
that referenced
this pull request
Mar 29, 2012
Missed commits from 3-2-stable
|
Thank you @avakhov ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By accident I found that commit f29b4a0 (Add a test case for layout nil) exists only in 3-2-stable branch. I wrote simple script and compare commits between master & 3-2-stable.
It likes that at least these 4 changes are committed only in 3.2 but missed in master.
@josevalim, @carlosantoniodasilva, @bsodmike, they are really missed, aren't they?