Fix build for branch 3-2-stable - return the same session hash object #5597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure to return the same hash object instead of returning a new one. Returning a new one causes failures on cookie store tests, where it tests for the 'Set-Cookie' header with the session signature. This is due to the hash ordering changes on Ruby 1.8.7-p358.
josevalim
added a commit
that referenced
this pull request
Mar 26, 2012
Fix build for branch 3-2-stable - return the same session hash object
This was referenced Mar 26, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the build for branch 3-2-stable. It's currently green on travis by chance, due to randomly errors happening on Ruby 1.8.7 p538.
Branch 3-1 on travis actually showed up the error related to cookie store tests.
The idea behind this is to ensure the session hash that will be used to set the cookie value by rack shouldn't change, whereas right now it returns a new hash object every time
set_sessionis called. With the random hash change in Ruby 1.8.7, it was causing the failures when testing against the generatedSet-Cookieheader.Given this is applied and 3-2 tests pass, I'll send to 3-1 as well - and I think the same patch could be applied later to master as it makes sense to not return a different object.
/cc @josevalim @spastorino