Incorporating Pacific Island zone changes circa Dec 31 2011 #5838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amoa. Further, Samoa and Tokelau jumped across the IDL from Dec 29 to Dec 31, 2011 switching from UTC-11 to UTC+13. American Samoa did not make the change and remains at UTC-11. Pacific/Fakaofo and Pacific/Apia are in TZInfo and documentation about the dateline change is in austalasia at IANA.
|
Sounds ok to me. Not sure if we need some tests. @pixeltrix can you take a quick look please? |
pixeltrix
added a commit
that referenced
this pull request
Apr 30, 2012
Incorporating Pacific Island zone changes circa Dec 31 2011
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correcting some confusion. The Pacific/Pago_Pago zone should have been labeled "American Samoa" not "Samoa". They're 75 miles apart but different.
It's especially important because at the end of 2011 Samoa (and also Tokelau) jumped across the international dateline to be on the same day as New Zealand and Australia. They switched to UTC+13 and left American Samoa at UTC-11.
Documentation about the dateline change is at IANA in the file 'austalasia'.
Pacific/Fakaofo and Pacific/Apia are in TZInfo and present in ruby 1.9.3. Perhaps this is a Rails 4.0 tweak.