Make callstack attribute optional in AS:Deprecation

[gazay]

It's unnecessary to send caller from all places where used ActiveSupport::Deprecation.warn, because we can only call caller(2) from warn method and get the same callstack

[carlosantoniodasilva]

If we're going down this path, I think we could deprecate the callstack argument.

@josevalim any concern about this?

[josevalim]

@carlosantoniodasilva I don't think we need to deprecate, it may still be useful in some rare occasions.

@jeremy this looks good, c/d?

[carlosantoniodasilva]

@josevalim alright, tks.

[steveklabnik]

This will need a rebase.

[gazay]

@steveklabnik done. I've added optional callstack functionality to new method too - deprecation_warning of ActiveSupport::Deprecation::Reporting. And entry to Changelog.

[carlosantoniodasilva]

@gazay now this needs a new rebase :). You can also extend it and take a look at some other places where caller is given, to remove it (like some of the places from the other pull request you commented).

[gazay]

Yep, I'm on it right now.

[gazay]

@carlosantoniodasilva done

[carlosantoniodasilva]

@gazay Nice, thank you.