Fix regression #6558
Merged
Fix regression #6558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ebfa58a. This change caused a regression in my application's tests: * Failing build http://travis-ci.org/#!/resolve/refinerycms/builds/1461242 Broken tests pass after this change is reverted.
tenderlove
added a commit
that referenced
this pull request
May 31, 2012
* 3-2-rel: bumping to 3.2.4 adding security notifications to CHANGELOGs updating changelogs Merge pull request #6558 from parndt/fix_regression
|
This appears to break ActiveRecord::Base#first and #last. To reproduce the bug: Post.first #=> nil
post = Post.create(:name => "test")
Post.first #=> post
post.destroy
Post.first #=> postThe last Post.first should not be returning the destroyed record. |
|
+1 to @tgildea. This commit breaks Model.last in our app's test suite. (by git-bisecting from v3.2.3 to v3.2.4) |
|
This causes Spree's API component to break also. Also found by git-bisecting just like @ktheory. |
|
Same here. This patch is causing failures in rubygems.org. Reverting this commit fixes the problem. |
|
@parndt can you explain more about the issue you encountered? I would like to add a test to prevent this regression re-occurring in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit ebfa58a.
This change caused a regression in my application's tests:
Broken tests pass after this change is reverted.