Remove extra test case. #6784
Merged
Remove extra test case. #6784
+4
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,8 +6,10 @@ def setup | |||
| @bc.add_filter { |line| line.gsub("/my/prefix", '') } | |||
| end | |||
|
|
|||
| test "backtrace should not contain prefix when it has been filtered out" do | |||
| assert_equal "/my/class.rb", @bc.clean([ "/my/prefix/my/class.rb" ]).first | |||
| test "backtrace should filter all lines in a backtrace" do | |||
There was a problem hiding this comment.
Although the tests have similar assertions, the description is quite different. Perhaps we could use something like:
"backtrace should filter all lines in a backtrace removing prefixes"
wdyt?
|
Works for me. Thanks for the feedback. |
|
Thanks. I'll have to ask you to squash the commits into one, and push force to your branch, so we can merge. |
Make the test description better reflect what is happening
|
All yours. Thanks. |
carlosantoniodasilva
added a commit
that referenced
this pull request
Jun 19, 2012
Remove extra test case.
|
Great, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very small change that removes what I consider a duplicate test.
Comments welcome.