remove duplicate build runs in travis #7151
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These extra runs were used to test identity map and not fully removed when the feature was removed.
When identity map was removed, ci/travis.rb was updated to remove the line in the if build.activerecord? clause that sets the :identity_map build option to true. However, the entire if build.activerecord? clause needs to be removed to remove the extra build.run! inside the clause.
Currently, for each database, activerecord tests are run 4 times, twice not in isolation, and twice in isolation. They only need to be run twice, once not in isolation, and once in isolation.
To validate the fix, I have run ci/travis.rb against all the variations of the GEM environment variable as specified in .travis.yml. All tests ran successfully and there were no duplicate runs. I ran the tests using ruby 1.9.3 in a vagrant box provisioned based on the same travis cookbook recipes that the travis standard worker box uses.
Please let me know any more work I need to do for this fix.