Ported PR #4856 to 3-2-stable. #7299
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the feedback, @rafaelfranca. As far as I can tell, there's just one small change in #7173. I've backported #7173. Can you confirm this please and let me know if there's another commit that's not referenced that I've missed? Thanks. |
rafaelfranca
added a commit
that referenced
this pull request
Aug 9, 2012
Ported PR #4856 to 3-2-stable.
|
Merged. Thanks |
|
Thanks, @rafaelfranca. |
|
This fix also works with Oracle. Thanks for taking care of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
#4856 was committed to master, but never backported to 3-2-stable. I only realised when I upgraded Rails to the latest 3-2 version and it broke my app. I'd been using a patched version locally. My fail.
The files that were updated on master haven't changed on 3-2-stable, so it should be very straightforward.
Thanks,
iHiD