Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table#remove passed an array to remove_column, which is deprecated. #7388

Conversation

jrafanie
Copy link
Contributor

See 02ca915

I was noticing this warning using 3.2.8 even though I was doing:

t.remove :some_column

DEPRECATION WARNING: Passing array to remove_columns is deprecated, please use multiple arguments, like: `remove_columns(:posts, :foo, :bar)`

Attached is a fix for Table#remove rebased against 3-2-stable and tests updated to reflect that remove_columns should not be passed an array.

@jrafanie
Copy link
Contributor Author

cc @drogus

rafaelfranca added a commit that referenced this pull request Aug 18, 2012
…_deprecation

Table#remove passed an array to remove_column, which is deprecated.
@rafaelfranca rafaelfranca merged commit b3bea49 into rails:3-2-stable Aug 18, 2012
@jrafanie
Copy link
Contributor Author

Thanks @rafaelfranca

@rafaelfranca
Copy link
Member

Thank you.

@jrafanie jrafanie deleted the fix_table_remove_passing_array_deprecation branch May 10, 2016 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants