Please fix select_tag in 3.2.8

[Sega100500]

Hi!

In 3.2.7 this code was possible if 'auto_models_for_select' is nil :
<%= select_tag :model, auto_models_for_select, :include_blank => true,
:disabled => auto_models_for_select.nil? %>

In 3.2.8 this should be :
<%= select_tag :model, auto_models_for_select || '', :include_blank =>
true, :disabled => auto_models_for_select.nil? %>

If second parameter is nil it raise an exception.

Please, return back that it was possible to transfer nil of second
parameter - options.

[carlosantoniodasilva]

What exception is raised? What's the stack trace of the exception? Please send as much info as you can, thanks.

[Sega100500]

TypeError in Application#index

Showing (...) where line #32 raised:

can't convert nil into String

...

activesupport (3.2.8) lib/active_support/core_ext/string/output_safety.rb:114:in concat' activesupport (3.2.8) lib/active_support/core_ext/string/output_safety.rb:114:insafe_concat'
actionpack (3.2.8) lib/action_view/helpers/form_tag_helper.rb:125:in `select_tag'

[nashby]

@carlosantoniodasilva looks like we need to change nil to empty string here: https://github.com/rails/rails/blob/master/actionpack/lib/action_view/helpers/form_tag_helper.rb#L120

or make safe_concat to accept nil

[carlosantoniodasilva]

Seems like it worked "by chance" so far:

>> ''.html_safe + nil
=> ""

And here's the culprit: a37c474. I think that ensuring option_tags is not empty should be enough, right?

options_tags ||= ''

[nashby]

yeah, this should work. Or:

def select_tag(name, option_tags = '', options = {})

?

[rafaelfranca]

@nashby this will not work in the case that the second argument is nil. We will have to ensure that option_tags is not nil.

[nashby]

@rafaelfranca right.

[Sega100500]

just add:
options_tags ||= ''

before work with options_tags in select_tag method