Fix ActiveRecord#update_column return value #8083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
pushed a commit
that referenced
this pull request
Oct 31, 2012
Fix ActiveRecord#update_column return value
|
We need a CHANGELOG entry for this |
|
@spastorino is it really necessary in this case, since it was added right before the rc1 was released, in cherry pick cdfa4a5? |
|
@carlosantoniodasilva got it, I doesn't need a CHANGELOG entry just an entry in rc2 release changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I have a fix for incorrect return value from
ActiveRecord#update_columnmethod.