Cache digest opt out cleanup #8339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@latortuga yes, there is not way to change already merged pull request. Thank you so much for this one. Could you squash the code change commits? Leave one for the CHANGELOG entry and another to the changes in the code. |
Instead of deleting the skip_digest option flag, this changes the method to merely check the key. This change is because of a discussion in this thread: rails#8317 This commit also makes #fragment_name_with_digest private due to its functionality being subsumed by #cache_fragment_name.
|
@rafaelfranca Sure thing, I squashed the code changes into one commit and rebased to current master. Thanks for the guidance! |
rafaelfranca
added a commit
that referenced
this pull request
Nov 27, 2012
Cache digest opt out cleanup
|
Thank you so much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per original discussion in this thread with @carlosantoniodasilva and @rafaelfranca, I have cleaned up the
CacheHelperchanges and added a CHANGELOG. I couldn't figure out how to add to the closed PR so I made a new one - hope that's okay!