Fixed #7245 Inconsistent output from ActiveSupport::TimeZone.all #8660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smondal first off, happy new year to you :) I'm wondering how one could test this - i.e. it'll need to be run in isolation? |
|
Happy new year to all..Please follow the ticket #7245. That was post by "wonnage" in 5 months back. Previous it was given inconsistent output. |
|
You should write a test-case to make sure the "previously" inconsistent behavior does no longer happen. This will prevent regressions from happening. (maybe you can use the one I wrote some time ago senny@9e6cb87) |
|
There is a competing PR for the same Issue #8377 |
|
It looks like the consensus on #7245 was to fix this issue in the view, so I think that this can probably be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now this is not given any inconsistent out.
ActiveSupport::TimeZone.all
chicago = ActiveSupport::TimeZone['America/Chicago']
ActiveSupport::TimeZone.all.include?(chicago)
=> false
chicago = ActiveSupport::TimeZone['America/Chicago']
ActiveSupport::TimeZone.all.include?(chicago)
=> false
This fixes #7245