cache_key does not consult updated_on

[bemurphy]

The Timestamp module accommodates for both updated_at and updated_on timestamps, while .cache_key only checks updated_at.

I'm thinking a sane strategy would be to check if either or both exist, and use the max of the result for the cache key. Thoughts?

[senny]

sounds reasonable. If we support updated_at, we should support it throughout the system.

@rafaelfranca what do you think?

[bemurphy]

I started a stab at it here: bemurphy@da73700

If we think it's a good idea, I can open a separate PR. I'm not very happy with that code though. It's a) messy and b) seems to know a lot about updated_ column names.

[senny]

can you make use of ActiveRecord::Timestamp#timestamp_attributes_for_update ? This would allow you to be independent of the exact names but still take all available names into account (it would even be dynamic).

https://github.com/rails/rails/blob/master/activerecord/lib/active_record/timestamp.rb#L89-L91

[bemurphy]

@senny yeah, I was looking at that earlier and thinking it looked useful. I'll take a stab in the morning, thanks.

[senny]

ping me here if you need further assistance. I think this is a good change.

[bemurphy]

@senny Maybe like bemurphy@e5e0b78. Still messy; I'm feeling hesitant to pollute the methods by extracting to #max_updated_timestamp or something, though.

[rafaelfranca]

Closed by #9105