fix repeat of test; remove unused variable by use of each_key

[vipulnsward]

1. The loop was unnecessarily repeating itself
2. Removed unused variable by use of each_key in place of each

[carlosantoniodasilva]

I wonder if there's a reason for that, or it's just historical due to ruby 1.8? Original commit: f0e754e

@fxn @norman can you please take a look?

[norman]

This is to get better error messages. The string created by line 20 is:

ÀÁÂÃÄÅÆÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖØÙÚÛÜÝÞßàáâãäåæçèéêëìíîïðñòóôõöøùúûüýþÿĀāĂ㥹ĆćĈĉĊċČčĎďĐđĒēĔĕĖėĘęĚěĜĝĞğĠġĢģĤĥĦħĨĩĪīĬĭĮįİıIJijĴĵĶķĸĹĺĻļĽľĿŀŁłŃńŅņŇňʼnŊŋŌōŎŏŐőŒœŔŕŖŗŘřŚśŜŝŞşŠšŢţŤťŦŧŨũŪūŬŭŮůŰűŲųŴŵŶŷŸŹźŻżŽž

In the event of a failure it's nicer to know exactly where it failed rather than "somewhere in there." A few of the characters don't actually decompose down to a letter and a diacritic, so the places where failures are most likely to arise due to refactoring the transliteration code are not intuitive to most people. I would leave this one alone.

[vipulnsward]

@norman So instead the test should be taking place on char variable instead of string right?
Because even if we are going over the whole string, we are just keeping on doing the same thing for all the characters, if I am not wrong.
ie. we do assert_match %r{^[a-zA-Z']*$}, ActiveSupport::Inflector.transliterate(string) instead of assert_match %r{^[a-zA-Z']*$}, ActiveSupport::Inflector.transliterate(char) repeatedly. Or is this intentional too?

[norman]

So instead the test should be taking place on char variable instead of string right?

Ah, yes that's right. I looked right past that.

[vipulnsward]

Updating the PR to reflect this then

[vipulnsward]

@carlosantoniodasilva @norman Fixed/Squashed it.

[carlosantoniodasilva]

Thanks @Normal @vipulnsward