Fix copy table index test; Change == to ! on false in travis.rb #9847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vipulnsward
commented
Mar 21, 2013
vipulnsward
commented
- Fix copy table index test, that was wrongly testing same thing
- Change == to ! on false value in travis.rb
|
Not sure, if I should have removed the extra hash form comments. |
|
@vipulnsward What do you think about this?
|
| @@ -117,7 +117,7 @@ def rake(*tasks) | |||
| # puts " Local gems:" | |||
| # `gem list`.each_line {|line| print " #{line}"} | |||
|
|
|||
| failures = results.select { |key, value| value == false } | |||
| failures = results.select { |key, value| !value } | |||
There was a problem hiding this comment.
I think this is checking false to avoid keys with nil value to be a failure
There was a problem hiding this comment.
The unless in the rake method handles nils
rafaelfranca
added a commit
that referenced
this pull request
Mar 21, 2013
Fix copy table index test; Change == to ! on false in travis.rb
|
Thank you ❤️ 💚 💙 💛 💜 |
|
😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.