Don't use self.class in ActiveRecord#sanitize_sql_hash_for_conditions. #10473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
self is already a class here, so don't call class on it again, otherwise the PredicateBuilder will call the non-existant Class#reflect_on_association. This makes Cancan's accessible_by useable with multiple rules involving polymorphic relations.
| def test_sanitize_sql_hash_handles_models_as_values | ||
| treasure = Treasure.new | ||
| treasure.id = 1 | ||
| assert_nothing_raised do |
There was a problem hiding this comment.
I think is better to assert the return of the sanitize_sql instead of assert_nothing_raised
|
Submitted this a few days ago: #10352 |
|
😅 how we will handle this? #10352 needs a rebase but has better tests. The CHANGELOG message here seems better. |
|
Updated CHANGELOG. #10352 |
|
I hadn't seen @zohlgren's PR; I will close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selfis already a class here, so don't callclasson it again, otherwisethe
PredicateBuilderwill call the non-existantClass#reflect_on_association.This makes Cancan's
accessible_byuseable with multiple rules involvingpolymorphic relations.