Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a case insensitive URI Regexp for #asset_path #10969

Merged
merged 1 commit into from Jun 17, 2013
Merged

Use a case insensitive URI Regexp for #asset_path #10969

merged 1 commit into from Jun 17, 2013

Commits on Jun 16, 2013

  1. Use a case insensitive URI Regexp for #asset_path 

    Context: https://gist.github.com/radar/5793814

The `URI_REGEXP` that various AssetUrl helpers use is currently case
sensitive when checking for a URI scheme. This means if you try to pass
a URL like `HTTP://www.example.com/path/to/image.jpg`, you end up with
a bogus asset path: `/assets/HTTP://www.example.com/path/to/image.jpg`.

URLs are case insensitive, so this regexp should be as well.

Signed-off-by: David Celis <me@davidcel.is>
    @davidcelis
    davidcelis committed Jun 16, 2013
    Configuration menu
    Copy the full SHA
    8fc3427 View commit details
    Browse the repository at this point in the history