#10161 Fix custom migration folder path #11071
Conversation
…older path set in the Rails application config
| @@ -8,7 +8,7 @@ class MigrationGenerator < Base # :nodoc: | |||
| def create_migration_file | |||
| set_local_assigns! | |||
| validate_file_name! | |||
| migration_template @migration_template, "db/migrate/#{file_name}.rb" | |||
| migration_template @migration_template, "#{Rails.application.config.paths['db/migrate'].first.to_s}/#{file_name}.rb" | |||
There was a problem hiding this comment.
Thanks. This should indeed be fixed but we are not supposed to access the configuration direclty. Instead, we should copy its value to somewhere like ActiveRecord::Base.migration_path on intiailization and rely on it instead. We also need a test to avoid future regressions. :)
|
2 months no activity @morcmarc have you had a chance to implement @josevalim's suggestions? Will you be able to continue working on this PR? |
|
Ah sorry guys, busy summer. I'll try to implement the suggested improvement and submit another pull request this week. |
|
@morcmarc it's been another three months. Are you still up to work on this or should we see if someone takes over? |
|
@josevalim, how about the implementation in PR #13376? |
|
It's not an error, but a feature instead from my point of view. It would allow me to get rid of this file: https://github.com/rosenfeld/active_record_migrations/blob/master/lib/active_record_migrations/generators/migration.rb |
|
The implementation in #13376 is still not ideal because it is relying on |
|
I can't think of any use case where the rake specific stuff would not be set and the generator would still be run. |
|
How about adding this path in ActiveRecord::Railtie in this initializer: https://github.com/rails/rails/blob/master/activerecord/lib/active_record/railtie.rb#L113-L119 |
|
Closing due inactivity. Thank you for the pull request. |
Removed hard coded migration folder path from the create new migration method.