fix grammar, change 'an' to 'a' [ci skip] #11139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,8 +28,8 @@ class Deprecation | |||
| # The version the deprecated behavior will be removed, by default. | |||
There was a problem hiding this comment.
Not able to understand meaning of this line. We need to change this line too.
There was a problem hiding this comment.
please go ahead and change that line too, no need for a separate PR.
There was a problem hiding this comment.
@senny i don't understand the meaning of that line 😄
There was a problem hiding this comment.
the variable specifies the version when the deprecated behavior will be removed. It is the default value and can be overridden if you create a ActiveSupport::Deprecation yourself.
There was a problem hiding this comment.
I suppose it says that :deprecation_horizon stores the version [number] [in which] the deprecated behavior will be removed, by default.
senny
added a commit
that referenced
this pull request
Jun 27, 2013
fix grammar, change 'an' to 'a' [ci skip]
|
thanks. |
|
@khustochka @senny thanks 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.