Fixing encoding of non-string arrays #11159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct casting string values (from parameters, for example) to target types inside arrays
|
@steveklabnik ping :) |
|
I don't have enough experience with AR to know what's up in this code, sorry. It seems fine, but I'm not comfortable merging. |
|
👍 |
|
Tried to apply only the tests on latest master, and seems that the issue still exist.. |
|
@arthurnn I'll take a look. |
|
@arthurnn can you still reproduce the error? I just applied the tests on |
|
@arthurnn just to clarify, the current cast refactoring should not have had any impacts on this issue. We kept the existing type casting mechanics and rearranged them. However I did a lot of work on the PG specific types lately. It might be related to that. Anyway, thanks for closing 💛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When array of non-string values assigned from array of strings (controller params, for example) it blows up with NoMethodError: undefined method `gsub' in quote_and_escape
It's because of quote_and_escape is called for values, which are strings before cast, while after casting it may become something other than string.
This patch fixes it, by calling quote_and_escape for values, which are strings after cast, not before.