Creating a class for carrying out rails commands.

[wangjohn]

This class encapsulates a lot of logic that wasn't very object oriented. The file for defining rails commands had quite a bit of logic inside of it which could be refactored. I've created a new class which handles the delegation of the commands.

Helper methods have been created to try to make things more logical and easy to read.

[mdespuits]

👍 Awesome!

[carlosantoniodasilva]

Should use the argv attribute instead of the ARGV constant?

[rafaelfranca]

As far I could understand the next command will use the ARGV constant to perform the actions, so we have to mutate the ARGV

[wangjohn]

Yes, unfortunately, the file that is required in this command will look for --version to be the first argument in ARGV. The reason I choose to use ARGV instead of the argv instance variable is because it would be more clear that we are actually mutating the elements.

I'm using argv elsewhere when we only need to read. I'm still trying to think of a better way to get around all this terrible ARGV manipulation.

[carlosantoniodasilva]

I feel like manipulating the argument vs manipulating a constant would be better to go with the first, you can test more easily and the end result for the user (ie mutating ARGV and commands working) would be the same, since ARGV is what is passed as input to this class. As long as the warning shows that it mutates the variable, we should be good (Otherwise there might be no gain on passing ARGV as input since you could reference the constant everywhere for reading as well). But that's my opinion, others might disagree ;)

[guilleiguaran]

great!!!! ❤️