Fixes #11454 . We should define the return type of select_all method clearly. #11461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,8 +18,7 @@ def to_sql(arel, binds = []) | |||
| end | |||
| end | |||
|
|
|||
| # Returns an array of record hashes with the column names as keys and | |||
| # column values as values. | |||
| # Returns an ActiveRecord::Result instance with columns and rows methods. | |||
There was a problem hiding this comment.
I think it's enough to say: "Returns an ActiveRecord::Result instance". However we should improve the documentation of ActiveRecord::Result.
|
Can you squash the commits and maybe also improve the docs on |
|
hi @senny. I also try to add some usage comments. Please some advise for me :) |
| # result = ActiveRecord::Base.connection.exec_query('SELECT id, title, body FROM posts') | ||
| # result # => #<ActiveRecord::Result:0xdeadbeef> | ||
| # | ||
| # # Gets column name array. |
There was a problem hiding this comment.
I would reword this to: "Get the column names of the result:"
|
@kennyj looks great! 💛 |
|
thank you for your advises, @senny |
|
This looks good. Can you add |
|
okay. I've already updated. |
senny
added a commit
that referenced
this pull request
Jul 22, 2013
Fixes #11454 . We should define the return type of select_all method clearly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11454.
Now
select_allandselectmethods return an ActiveRecord::Result instance.I think we should define the return type of select_all method clearly, and fix related comments.