add support for html attributes to grouped_options_for_select #11517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if divider | ||
| label = divider | ||
| else | ||
| label, container = container | ||
| end | ||
| body.safe_concat content_tag(:optgroup, options_for_select(container, selected_key), :label => label) | ||
|
|
||
| body.safe_concat content_tag(:optgroup, options_for_select(container, selected_key), { :label => label }.merge(html_attributes)) |
There was a problem hiding this comment.
What do you think about splitting this line to make it more usable for reviewing on GitHub?
|
👍 |
|
@pftg hey, thanks for the comments! I didn't update tests since it already has a lot of long strings and actually I'm not sure what's the best way of splitting it :) |
drogus
added a commit
that referenced
this pull request
Jul 22, 2013
add support for html attributes to grouped_options_for_select
cgunther
added a commit
to cgunther/rails
that referenced
this pull request
Feb 14, 2022
PR rails#11517 updated `grouped_options_for_select` to allow passing HTML attributes of the optgroup as the last element of each array, which is called internally by `select` when it detects grouped choices. However, the `select` helper detected grouped choices by seeing if the [last element is an Array](https://github.com/rails/rails/blob/6ec669b65d5cd47c984661920d670faccbf0920a/actionview/lib/action_view/helpers/tags/select.rb#L37), meaning if you passed a hash of HTML attributes, it would no longer treat the choices as grouped. This conflicted with `grouped_options_for_select`, which assumes the individual options are the [second element](https://github.com/rails/rails/blob/6ec669b65d5cd47c984661920d670faccbf0920a/actionview/lib/action_view/helpers/form_options_helper.rb#L546), not the last element. Now there's agreement between `select` and `grouped_options_for_select` in expecting the individual option choices to be the second element, allowing the hash of HTML attributes to exist as the last element and properly trigger grouped options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.