Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert fixes #12173

Merged
merged 4 commits into from Sep 10, 2013
Merged

Conversation

arunagw
Copy link
Member

@arunagw arunagw commented Sep 9, 2013

I don't know what happens here but seems to many things have been reverted

ec8ef1e

I have add few back as far as I know of. I will look more of these from this commit.

1. As we have vendor in AV only
2. No more vendor in AC
3. No vendor folder in AR
@arunagw
Copy link
Member Author

arunagw commented Sep 10, 2013

@rafaelfranca can you check this ?

Also can you check this commit ec8ef1e

guilleiguaran added a commit that referenced this pull request Sep 10, 2013
@guilleiguaran guilleiguaran merged commit 005b332 into rails:master Sep 10, 2013
},

'actionview' => {
:include => %w(
README.rdoc
lib/action_view/**/*.rb
)
),
:exclude => 'lib/action_view/vendor/*'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't follow why adding an exclude here but removing the others? Don't they have vendor folders, is that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because there are no folders in others called 'vendor'

@arunagw arunagw deleted the fixes_reverted_by_revert_commit branch September 10, 2013 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants