Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce allocations when extracting AR models #12185

Merged
merged 1 commit into from
Sep 11, 2013
Merged

Reduce allocations when extracting AR models #12185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 13 additions & 1 deletion activerecord/lib/active_record/associations/join_dependency/join_part.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,19 @@ def column_names_with_alias
end

def extract_record(row)
Hash[column_names_with_alias.map{|cn, an| [cn, row[an]]}]
# This code is performance critical as it is called per row.
# see: https://github.com/rails/rails/pull/12185
hash = {}

index = 0
length = column_names_with_alias.length
while index < length
column_name,alias_name = column_names_with_alias[index]
hash[column_name] = row[alias_name]
index += 1
end

hash
end

def record_id(row)
Expand Down