Removes unused code related to DatabaseTasks. #12245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
pushed a commit
that referenced
this pull request
Sep 16, 2013
Removes unused code related to DatabaseTasks.
|
@kennyj : Sorry if I'm wrong ; I'm not very comfortable with ActiveRecord but are you dropping support for other RDBMS than MySQL, SQLite3 and PostgreSQL ? |
|
@kennyj : Thanks for the explanation! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found some unused code related to DatabaseTasks.
When I removed Oracle / SqlServer / Firebird Tasks, I also should have removed this code.
Related to 42d0d18 , 6b16b2f , 6649140