Extract .next_migration_number into module for third party generators.
#12407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rafaelfranca @carlosantoniodasilva can you take a look? |
|
|
senny
added a commit
that referenced
this pull request
Sep 30, 2013
…to_module Extract `.next_migration_number` into module for third party generators.
|
@rafaelfranca thank you ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many third party generators, who need to generate migrations copy the
.next_migration_numbermethod. This is necessary because most of the time you can't extendActiveRecord::Generators::Basebecause it's superclass isRails::Generators::NamedBase. Some examples:This copying has the negative effect that over time every implementation will be slightly different and falls out of sync.
This PR bundles the necessary functionality for Active Record Migration generators inside a new module
ActiveRecord::Generators::Migration. This module getsmigration_templateworking without any further configuration.