Add No Touching

[dmathieu]

This adds #no_touching on all ActiveRecord models, allowing to ignore touching for the duration of a block.

Example:

ActiveRecord::Base.no_touching do
  Post.first.touch #=> Does nothing
end

Comment.no_touching do
  Comment.first.touch #=> Does nothing
  Post.first.touch #=> Updates, but won't update related comments if there are any
end

cc @dhh

[rafaelfranca]

Why is not this inside the ClassMethods module?

[dmathieu]

If I put them in the ClassMethods module, I can't access them through NoTouching.apply_to, like we do at line 22.
And it means the model gets the apply_to and applied_to? methods, while here, they're only in the module.

[rafaelfranca]

Oh, right. Please put # :nodoc: in the methods

[dmathieu]

Done! 🌞

[egilburg]

I think without_touch or 'without_touching` sounds better.

[dhh]

I like the fun of no_touching.

On Nov 5, 2013, at 8:33, Eugene Gilburg notifications@github.com wrote:

I think without_touch or 'without_touching` sounds better.

—
Reply to this email directly or view it on GitHub.

[sausman]

I like the sound of no_touch.

[nijikon]

+1 for no_touch

[mbhnyc]

no_touchy_touchy maximizes fun, while also maximizing awkwardness!

[dmathieu]

From experience the "fun" things in rails don't stick around (I'm thinking of the snowman for example).
So I renamed it to no_touch in my pull request.

[nijikon]

👍

[dhh]

Eh, what? Look up #forty_two. Do rename it back.

On Nov 6, 2013, at 16:59, Damien Mathieu notifications@github.com wrote:

From experience the "fun" things in rails don't stick around (I'm thinking of the snowman for example).
So I renamed it to no_touch in my pull request.

—
Reply to this email directly or view it on GitHub.

[rafaelfranca]

This code is not thread safe. We need to store in a thread local variable.

[dmathieu]

I've fixed the thread safe problem.

[dhh]

Besides these few comments I just added, are we otherwise ready to merge?

[dmathieu]

I just applied your two comments.

[lukaszx0]

I liked @steveklabnik's idea of calling it #cant_touch_this the most 🤘

[guilleiguaran]

LOL

Sent from my iPhone

On 20 Nov 2013, at 09:02 pm, Łukasz Strzałkowski notifications@github.com wrote:

I liked @steveklabnik's idea of calling it #cant_touch_this the most

—
Reply to this email directly or view it on GitHub.

[arenoir]

@dmathieu this is very handy, however it seems after_touch callbacks still get run. Is there a way to disable after_touch callbacks?