random test order fixes for PostgreSQL #12939
Conversation
|
Can you please squash these commits into one, do you have a copy of the output of failing tests in random order? |
|
output: https://gist.github.com/hegyi/7531605 |
|
Thanks, sorry about the rebase comment I meant to ask you to squash the commits to one. — On Mon, Nov 18, 2013 at 11:22 AM, Adam Hegyi notifications@github.com
|
resetting columns skipping temporary destroy callback restoring old Owner class after assertion restoring original sequence remove puts
| @@ -35,6 +35,8 @@ def test_multiline_default_text | |||
| # older postgres versions represent the default with escapes ("\\012" for a newline) | |||
| assert( "--- []\n\n" == Default.columns_hash['multiline_default'].default || | |||
| "--- []\\012\\012" == Default.columns_hash['multiline_default'].default) | |||
| ensure | |||
| Default.reset_column_information | |||
There was a problem hiding this comment.
what line modifies the column information so that we need to reset it?
There was a problem hiding this comment.
I'm not sure about this one, I need to check it
There was a problem hiding this comment.
I put the reset in the wrong test case. I created a gist where you can see the problem: https://gist.github.com/hegyi/7547694
reset column information seems to work but I have no idea why.
I fixed some failing test cases (not ALL) while running the tests in random order.