Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite >= 3.8.0 supports partial indexes #13350

Merged
merged 1 commit into from Jan 14, 2014

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Dec 17, 2013

No description provided.

@rafaelfranca
Copy link
Member

@rafaelfranca rafaelfranca commented Dec 17, 2013

Do we have tests for this?

@ccutrer
Copy link
Contributor Author

@ccutrer ccutrer commented Dec 17, 2013

there are now (the schema dumper needed to be updated)

@ccutrer
Copy link
Contributor Author

@ccutrer ccutrer commented Jan 10, 2014

any update on this?

@@ -1,3 +1,7 @@
* Enable partial indexes for sqlite >= 3.8.0
Copy link
Member

@senny senny Jan 14, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@senny
Copy link
Member

@senny senny commented Jan 14, 2014

@ccutrer this is looking good 💛! I added some minor comments. Can you push a rebased version?

@ccutrer
Copy link
Contributor Author

@ccutrer ccutrer commented Jan 14, 2014

@senny thanks for the comments. rebased and updated.

@senny
Copy link
Member

@senny senny commented Jan 14, 2014

👍

senny added a commit that referenced this issue Jan 14, 2014
sqlite >= 3.8.0 supports partial indexes
@senny senny merged commit 93b38d5 into rails:master Jan 14, 2014
@mszyndel
Copy link

@mszyndel mszyndel commented Jun 13, 2014

Can we backport this to Rails 4.0?

@senny
Copy link
Member

@senny senny commented Jun 13, 2014

new features will not be backported, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants