Skip to content

sqlite >= 3.8.0 supports partial indexes#13350

Merged
senny merged 1 commit intorails:masterfrom
ccutrer:sqlite-partial-indexes
Jan 14, 2014
Merged

sqlite >= 3.8.0 supports partial indexes#13350
senny merged 1 commit intorails:masterfrom
ccutrer:sqlite-partial-indexes

Conversation

@ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Dec 17, 2013

No description provided.

@rafaelfranca
Copy link
Member

Do we have tests for this?

@ccutrer
Copy link
Contributor Author

ccutrer commented Dec 17, 2013

there are now (the schema dumper needed to be updated)

@ccutrer
Copy link
Contributor Author

ccutrer commented Jan 10, 2014

any update on this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@senny
Copy link
Member

senny commented Jan 14, 2014

@ccutrer this is looking good 💛! I added some minor comments. Can you push a rebased version?

@ccutrer
Copy link
Contributor Author

ccutrer commented Jan 14, 2014

@senny thanks for the comments. rebased and updated.

@senny
Copy link
Member

senny commented Jan 14, 2014

👍

senny added a commit that referenced this pull request Jan 14, 2014
sqlite >= 3.8.0 supports partial indexes
@senny senny merged commit 93b38d5 into rails:master Jan 14, 2014
@mszyndel
Copy link

Can we backport this to Rails 4.0?

@senny
Copy link
Member

senny commented Jun 13, 2014

new features will not be backported, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants