Fix to_param when attribute has multibyte character

[rono23]

When attribute has only multibyte character, to_param returns id + "-". I think it is not pretty.

[rafaelfranca]

This seems good to me. @javan what do you think? Will this break any behavior we are relying?

[pixeltrix]

Typically to_param values are to be used as part of a URI path so should be valid pchar according to RFC 3986, so I think this change makes sense.

[javan]

👍 on the change. I'm not crazy about building on the nest of (...).present? checks though. Perhaps define each var first and just use those in the conditional. Up to you guys.

[norman]

When I wrote the transliterate method used internally by parameterize I didn't change the API at all in order to get it into Rails 3 fairly close to its release. But one thing I've never liked is the fact that transliterate has no option to preserve UTF-8 characters it can't transliterate. Essentially, to_param is more or less useless for Russian, Arabic, Hebrew, Japanese, Korean, Chinese, Vietnamese, Hindi, and other languages used by more than half of the world's population.

Unicorn mode ON:

It would be nice, I think, to allow an option to not delete UTF-8 characters, so that you could generate a parameterized string like 4-戦場ヶ原-ひたぎ if you want to.

Unicorn mode OFF.

[rafaelfranca]

@norman I agree with you but even if we generate parameterized string with UTF-8 characters our router is not prepared to handle it very well (I was bite for a lot of bugs related with this in the last month). So I think we should stay with this version here and when we change the router to handle UTF-8 characters we can change transliterate

[pixeltrix]

Yep, fine for 4.1 and then look at it again when we support IRIs

[rono23]

@javan Thank you for your feedback. I will fix like below and then rebase, fine?

result = send(method_name).to_s
param = result.squish.truncate(20, separator: /\s/, omission: nil).parameterize

if (default = super()) && param.present?

[javan]

Actually, the short-circuiting nature of the current structure makes the most sense. We don't need result unless there's a default and don't need param unless there's a result. I guess leave it as-is or fix up the formatting a little. I'm not sure what the preferred style in Rails is, perhaps:

define_method :to_param do
  if (default = super()) && 
       (result = send(method_name).to_s).present? &&
         (param = result.squish.truncate(20, separator: /\s/, omission: nil).parameterize).present?
    "#{default}-#{param}"
  else
    default
  end
end

[rono23]

I don't know preferred style, but we can find both, ex) here and here etc.
I will wait for responses from others. Thanks!

[rafaelfranca]

You can use the one @javan used here.

[rono23]

@rafaelfranca Thank you! I will fix it and force push.

[rono23]

@javan @rafaelfranca Thank you for your advice. I updated the style.

[rafaelfranca]

Thank you so much for trying the beta and fixing this bug.

[kuldeepaggarwal]

@rafaelfranca So, does Rails support Unicode character routes ?

[pixeltrix]

@kuldeepaggarwal RFC 3986 requires path chars other than alphanumerics to be %-encoded. HTML5 includes partial support for IRIs and it's something we'll be investigating for a future version of Rails.

[jeremy]

Please Do Investigate support for routing IRIs in Journey!

Major performance win if we can avoid transliteration when we to_param to generate slugs.