Fix DB Console tests #13443
Merged
Fix DB Console tests #13443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build is broken: https://travis-ci.org/rails/rails/builds/15824530 This commit fixes it. The problem: Sqlite expects the `database` part to be an absolute path. That prompted this change to be committed to master: rails@fbb79b5 This change provides correct behavior. Unfortunately tests were introduced in rails@971d510 that were relying on the incorrect behavior. We can avoid the fix by changing to another database url such as `mysql` or `postgresql` In addition to fixing the failure, the assertions are changed so that the "expected" value comes before "actual" value.
|
I have already sent a PR #13439 for this. |
|
All tests are green, no code was harmed in the making of this PR (only modified tests) |
schneems
referenced
this pull request
Dec 22, 2013
| } | ||
| } | ||
| app_db_config(sample_config) | ||
| assert_equal Rails::DBConsole.new.config["host"], "dburl" | ||
| assert_equal host, Rails::DBConsole.new.config["host"] | ||
| end |
There was a problem hiding this comment.
Having to change all this seems unexpected =(
|
@carlosantoniodasilva wanted to switch the order to have valid expected versus actual: 971d510 It was also unclear that only the host value was being compared and it was expected. Since I was already modifying the line I decided to update the rest of it. The minimum required change would have been |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build is broken: https://travis-ci.org/rails/rails/builds/15824530
This commit fixes that.
The problem: Sqlite expects the
databasepart to be an absolute path. That prompted this change to be committed to master: fbb79b5This change provides correct behavior. Unfortunately tests were introduced in 971d510 that were relying on the incorrect behavior. We can avoid the fix by changing to another database url such as
mysqlorpostgresqlIn addition to fixing the failure, the assertions are changed so that the "expected" value comes before "actual" value.
More tests fixed by specifying absolute paths rather then relative.