Fix for ruby 1.8 bug with ActiveSupport::OrderedHash #1359

Merged
merged 1 commit into from May 27, 2011

Projects

None yet

3 participants

@AndrewRadev
Contributor

An example of the problem can be seen in this gist: https://gist.github.com/994919.

Basically, ActiveSupport::OrderedHash behaves differently than the built-in Hash when yielding to a block that accepts its parameters with a splat. This is only an issue on ruby 1.8 because 1.9 uses the built-in Hash at all times. It's a very minor inconsistency, but it causes some problems with pp, for example.

Tested with rvm-installed ruby 1.8.7-p330, on Mac OS X 10.6.7. At least on this machine, tests are all running green.

@AndrewRadev AndrewRadev Fixes minor ruby 1.8 inconsistency
ActiveSupport::OrderedHash did not behave identically to Hash when given
a block with a splat.
c9cc36b
@josevalim josevalim merged commit 4ae8381 into rails:master May 27, 2011
Owner

This now makes each_pair different for 1.8 and 1.9 - is this what we want? Anybody using each_pair on ordered hashes is now going to have implement a version check - developers writing apps probably won't be affected that much but what about gem/plugin authors using Active Support? If you've gone to the trouble of using an AS::OrderedHash in a gem it's likely you'll want the same behaviour on 1.8 and 1.9.

Member

@pixeltrix Does each_pair behaves differently on 1.8 and 1.9 for Hash? If so, it is ok for us to be differently here, if not, we should revert this.

Owner

Yes it behaves differently - my concern is that a gem/plugin may be using AS:OrderedHash for consistent behavior between 1.8 and 1.9. It at least needs to be noted in the CHANGLOG. :-)

Member

Agreed.

Contributor

I added an entry to the CHANGELOG on my fork: AndrewRadev/rails@07a353d. I can't tell if this information is enough, though. Should I explain it in a bit more detail?

Um, I also don't actually know how to add it to this pull request, or even if it's possible considering it's closed :). Sorry, I'm afraid I'm not very experienced with pull requests.

Member

@AndrewRadev it looks good. However this fix is not going into 3-1-stable. So you just need to put it above. As per the pull request, you have to send a new one and then just link here. Thanks for your work!

Contributor

this fix is not going into 3-1-stable

Sorry about that, moved it under 3.2.0. Here's the link to the pull request, hope it's okay now: https://github.com/rails/rails/pull/1378/commits

Thanks for your work!

Glad I could help :).

@jake3030 jake3030 pushed a commit to jake3030/rails that referenced this pull request Jun 28, 2011
@aaronbatalion @dhh aaronbatalion + dhh Added optimal formatted routes to rails, deprecating the formatted_* …
…methods, and reducing routes creation by 50% [#1359 state:committed]

Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
fef6c32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment