New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup Bundler in engines bin/rails
stub.
#13696
Conversation
This is necessary when bundling gems locally using `BUNDLE_PATH`. Without this patch `bin/rails` fails with: ``` /Users/senny/.rbenv/versions/2.0.0-p353/lib/ruby/site_ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55:in `require': cannot load such file -- rails/all (LoadError) from /Users/senny/.rbenv/versions/2.0.0-p353/lib/ruby/site_ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55:in `require' from bin/rails:7:in `<main>' ```
I don't know a best way to test it either. I think the current tests are still doing this right? |
@rafaelfranca by doing this you mean call |
Yes, running bundle install. I think |
@rafaelfranca so you suggest to create a second slooo running test or modify the existing one to verify both, the current behvaior and also the binstub? |
If we can verify both in the same test I'd go with this option |
@rafaelfranca I can't even get it working using |
Sadly there is no clean way to verify this behavior in our test suite. I'm going to commit this as-is and backport it to |
setup Bundler in engines `bin/rails` stub.
setup Bundler in engines `bin/rails` stub.
This is necessary when bundling gems locally using
BUNDLE_PATH
.Without this patch
bin/rails
fails with:I wasn't sure what's the best way to test this, without effectively calling bundle and using a
BUNDLE_PATH
, which would take some time.