Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression on .select method #13886

Merged
merged 1 commit into from Jan 30, 2014
Merged

Fix regression on .select method #13886

merged 1 commit into from Jan 30, 2014

Commits on Jan 30, 2014

  1. Fix regression on .select_* methods. 

    This was a common pattern:
```
query = author.posts.select(:title)
connection.select_one(query)
```

However `.select` returns a ActiveRecord::AssociationRelation, which has
the bind information, so we can use that to get the right sql query.

Also fix select_rows on postgress and sqlite3 that were not using the binds

[fixes rails#7538]
[fixes rails#12017]
[related rails#13731]
[related rails#12056]
    @arthurnn
    arthurnn committed Jan 30, 2014
    Configuration menu
    Copy the full SHA
    b7fcad8 View commit details
    Browse the repository at this point in the history