Remove autoload for non-existing constants #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
added a commit
that referenced
this pull request
May 31, 2011
Remove autoload for non-existing constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously ActionView contained TemplateHandler, TemplateHandlers (@d182b6ee9c99901553e6 removed them), but declarations of autoload for these constants are still there. I've removed them in this patch since they don't exist anymore.
Backstory:
I've found out about this when was figuring out why haml stopped working with latest head of rails. Turned out haml was checking for ActionView.const_defined?("TemplateHandlers") which returned true because of autoload for this constant, but was failing afterwords since this constant doesn't exist.