Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle tzinfo-data on :x64_mingw (64-bit Ruby on Windows). #14720

Merged
merged 1 commit into from
Apr 12, 2014

Conversation

philr
Copy link
Contributor

@philr philr commented Apr 12, 2014

On Windows, the default Rails 4.1.0 Gemfile includes the following line:

# Windows does not include zoneinfo files, so bundle the tzinfo-data gem
gem 'tzinfo-data', platforms: [:mingw, :mswin]

However, this doesn't match 64-bit Windows MinGW builds of Ruby (such as the x64 RubyInstaller build). Users on this platform will encounter a TZInfo::DataSourceNotFound exception starting Rails unless they manually alter their Gemfile.

This pull request adds :x64_mingw to the platforms, so that tzinfo-data is also used on 64-bit MinGW Ruby builds.

rafaelfranca added a commit that referenced this pull request Apr 12, 2014
Bundle tzinfo-data on :x64_mingw (64-bit Ruby on Windows).
@rafaelfranca rafaelfranca merged commit 76fcbf3 into rails:master Apr 12, 2014
@philr philr deleted the tzinfo_data_x64_mingw branch October 27, 2014 20:47
@suriyaa
Copy link

suriyaa commented Nov 22, 2015

👍 Thanks! This is the only way to solve the tzinfo error in Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants