Baseclass becomes! subclass #14971
Merged
Baseclass becomes! subclass #14971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @klass.connection.update( | ||
| um = base_class.unscoped.where(base_class.arel_table[base_class.primary_key].eq(id_was || id)).arel.compile_update(substitutes, base_class.primary_key) |
There was a problem hiding this comment.
when we assign the expression inside where to a variable? This line is very hard to read...
condition = base_class.arel_table[base_class.primary_key].eq(id_was || id)
senny
added a commit
that referenced
this pull request
May 7, 2014
This case prevents against regressions. The change was suggested in a recent PR but the all our tests passed.
| Before this change, a record which changed its STI type, could not be found when updated. | ||
| Setting update_record to the base class, ensures the record can be found. | ||
|
|
||
| Fixes #14785 |
|
@senny Any idea on the status of this? Thanks! |
|
@VersionControl It's on my todo list. I will take a look in the upcoming days. |
|
Is there a milestone set for this? Will this be a part of 4.1.5? |
|
By what I could see it will be only part of Rails 4.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, a record which changed its STI type, could not be found when updated.
Setting update_record to the base class, ensures the record can be found.
The idea was proposed by @matthewd in #14887
Closes #14785