rafactored the regex related code in the mapper class #1523

Merged
merged 2 commits into from Jun 10, 2011

Conversation

Projects
None yet
3 participants
@raghunadhd
Contributor

raghunadhd commented Jun 7, 2011

No description provided.

@fxn

This comment has been minimized.

Show comment
Hide comment
@fxn

fxn Jun 7, 2011

Since these %r literals use no slashes as delimiters, some of the backslashes in the original code are no longer needed (and better removed).

Since these %r literals use no slashes as delimiters, some of the backslashes in the original code are no longer needed (and better removed).

@raghunadhd

This comment has been minimized.

Show comment
Hide comment
@raghunadhd

raghunadhd Jun 7, 2011

Owner

Ok. I will update the corresponding changes in the next commit. Thanks.
/cc @fxn.

Owner

raghunadhd commented on 2e07c71 Jun 7, 2011

Ok. I will update the corresponding changes in the next commit. Thanks.
/cc @fxn.

@raghunadhd

This comment has been minimized.

Show comment
Hide comment
@raghunadhd

raghunadhd Jun 10, 2011

Contributor

Commits Updated.

/cc @fxn

Contributor

raghunadhd commented Jun 10, 2011

Commits Updated.

/cc @fxn

@fxn

This comment has been minimized.

Show comment
Hide comment
@fxn

fxn Jun 10, 2011

Member

Thanks!

Member

fxn commented Jun 10, 2011

Thanks!

fxn added a commit that referenced this pull request Jun 10, 2011

Merge pull request #1523 from raghunadhd/refactor_regex
rafactored the regex related code in the mapper class

@fxn fxn merged commit 90c4885 into rails:master Jun 10, 2011

jake3030 pushed a commit to jake3030/rails that referenced this pull request Jun 28, 2011

Ensure auto_link doesnt linkify URLs in the middle of a tag [#1523 st…
…ate:resolved]

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>

jake3030 pushed a commit to jake3030/rails that referenced this pull request Jun 28, 2011

avoid auto_linking already linked emails; more robust detection of li…
…nked URLs

References #1523  [#1862 state:resolved]  [#3591 state:resolved]

Add test that shows how link text can contain HTML if needed:
the trick is using block form in combination with `raw`.
Let link text be automatically HTML-escaped

[#2017 state:resolved]

jake3030 pushed a commit to jake3030/rails that referenced this pull request Jun 28, 2011

avoid auto_linking already linked emails; more robust detection of li…
…nked URLs

References #1523  [#1862 state:resolved]  [#3591 state:resolved]

Add test that shows how link text can contain HTML if needed:
the trick is using block form in combination with `raw`.
Let link text be automatically HTML-escaped

[#2017 state:resolved]

svenfuchs pushed a commit to svenfuchs/rails that referenced this pull request Jul 2, 2011

avoid auto_linking already linked emails; more robust detection of li…
…nked URLs

References #1523  [#1862 state:resolved]  [#3591 state:resolved]

Add test that shows how link text can contain HTML if needed:
the trick is using block form in combination with `raw`.
Let link text be automatically HTML-escaped

[#2017 state:resolved]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment